src/db/migrations/20210314175439_fromName_null.ts

@@ -1,17 +0,0 @@
-import { Knex } from "knex";
-
-export async function up(knex: Knex) {
-  return knex.transaction((trx) =>
-    trx.schema.alterTable("voicemails", (table) => {
-      table.string("fromName", 64).alter();
-    })
-  );
-}
-
-export async function down(knex: Knex) {
-  return knex.transaction((trx) =>
-    trx.schema.alterTable("voicemails", (table) => {
-      table.string("fromName", 64).notNullable().alter();
-    })
-  );
-}

src/index.ts

@@ -68,24 +68,20 @@ async function initRingCentralSDK() {
     clientId: process.env.RC_APP_KEY,
     clientSecret: process.env.RC_APP_SECRET,
   });
-
-  const login = () =>
-    sdk.login({
+  const platform = sdk.platform();
+  platform.on(platform.events.refreshError, (err) => {
+    console.error("Refresh error", err);
+  });
+  const client = sdk.client();
+  client.on(client.events.beforeRequest, (request) => {
+    console.log(request.url);
+  });
+  await sdk.login({
     username: process.env.RC_LOGIN_USERNAME,
     extension: process.env.RC_LOGIN_EXT,
     password: process.env.RC_LOGIN_PASSWORD,
   });
-
-  const platform = sdk.platform();
-  platform.on(platform.events.refreshError, async (err) => {
-    console.error("Refresh token error:", err);
-    await login();
-    console.log("RingCentral re-authentication successful.");
-  });
-
-  await login();
   console.log("Authenticated to RingCentral.");
-
   return sdk;
 }
 

src/template.tsx

@@ -5,21 +5,19 @@ import { DateTime } from "luxon";
 import type { Contact } from "./types";
 import type { StoredVoicemail, StoredRecording } from "knex/types/tables";
 
-function fromName(vm: StoredVoicemail, contact?: Contact) {
-  return contact?.name ?? vm.fromName ?? "unknown";
-}
-
-export function getTicketSubject(vm: StoredVoicemail, contact?: Contact) {
-  const name = fromName(vm, contact);
-  return `New Voicemail from ${getNationalNumber(vm.fromNumber)} (${name})`;
+export function getTicketSubject(
+  voicemail: StoredVoicemail,
+  contact?: Contact
+) {
+  return `New Voicemail from ${getNationalNumber(voicemail.fromNumber)} (${
+    contact ? contact.name : voicemail.fromName
+  })`;
 }
 
 export function getTicketBody(
   vm: StoredVoicemail & StoredRecording,
   contact?: Contact
 ) {
-  const name = fromName(vm, contact);
-
   return ReactDOMServer.renderToStaticMarkup(
     <div>
       <div>
@@ -27,7 +25,8 @@ export function getTicketBody(
         {DateTime.fromISO(vm.received).toLocaleString(DateTime.DATETIME_MED)}
       </div>
       <div>
-        <b>From:</b> {getNationalNumber(vm.fromNumber)} ({name})
+        <b>From:</b> {getNationalNumber(vm.fromNumber)} (
+        {contact?.name ?? vm.fromName})
       </div>
       <div>
         <b>To:</b> {getNationalNumber(vm.toNumber)}x{vm.extensionNumber} (